S2699: Add UTs for Moq#9519
Merged
mary-georgiou-sonarsource merged 3 commits intomasterfrom Jul 11, 2024
Merged
Conversation
mary-georgiou-sonarsource
requested changes
Jul 11, 2024
Contributor
There was a problem hiding this comment.
Please:
- add the moq tests in their own moq file, add more tests for moq if there are any and also add some non-compliant tests cases too.
- update the comment here to reflect where moq comes from
maybe do a quick cleanup of the ruledone already - then if still moq is supported normally rename the PR to "Add UTs fro Moq" and close the issue as already supported.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7961
I was not able to reproduce the FP.
Since the rule checks for method invocations that include the
Verifyword, we already supportMoq.(see UnitTestHelper.cs)I made an update in rspec to mention it: https://github.com/SonarSource/rspec/pull/4052
I only added test cases with Moq usage.